Add additional param offset #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Param offset is needed when you are working with fixed elements. It fix the problems when you have some header which is fixed at the top of the page, and you are trying to check if some item is visible. When item is under the fixed header block, user doesn't see this item, but plugin returns true (item is visible), since it top offset is greater than 0. If you Pass param offset to visible function you'll check whether element is visible under offset. Param offset accepts simple number or object {top: 1, bottom: 2} etc.
|
👍 |
|
@EgorIgorevich I want to try your offset out – can you include its usage? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Param offset is needed when you are working with fixed elements. It fix the problems when you have some header which is fixed at the top of the page, and you are trying to check if some item is visible. When item is under the fixed header block, user doesn't see this item, but plugin returns true (item is visible), since it top offset is greater than 0. If you Pass param offset to visible function you'll check whether element is visible under offset. Param offset accepts simple number or object {top: 1, bottom: 2} etc.