Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't repeat mask images by default #239

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wimhendrikx
Copy link

No description provided.

@jssteinberg
Copy link

Out of curiosity, @wimhendrikx, since I can't remember using mask-image lately. I agree with sanitize.css not repeating background is a more intuitive default CSS behaviour, is it equally intuitive when it comes to mask-image? I guess it's clearly more consistent at least.

@wimhendrikx
Copy link
Author

Hi @jssteinberg , I myself use it a lot and the usage is a lot like background images but I use mask image with SVG images and background-color so I can determine the color in my CSS instead of in the SVG image. 90% of the time you don't want to repeat the image like it is the case with background images.

Copy link
Collaborator

@jonathantneal jonathantneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, @wimhendrikx. I’m generally in favor of this, for consistency. Would you have any research or examples to demonstrate the issue without it?

sanitize.css Outdated Show resolved Hide resolved
Co-authored-by: Jonathan Neal <[email protected]>
@wimhendrikx
Copy link
Author

Something like this @jonathantneal?

Before:

Scherm­afbeelding 2022-11-10 om 14 36 31

After:

Scherm­afbeelding 2022-11-10 om 14 36 38

jssteinberg added a commit to jssteinberg/some-makeup that referenced this pull request Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants