Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for custom sources #1504

Open
wants to merge 4 commits into
base: 5.x
Choose a base branch
from

Conversation

i-just
Copy link
Contributor

@i-just i-just commented Sep 2, 2024

Description

Adds support for importing into the relation fields that have custom source(s) selected.

  • assets field => you can't select a custom source as the field's source
  • categories field => the field can only have one source selected; it can be a custom source; in this PR I have:
    • disabled creating new categories if a custom source is selected (because of ensuring all the condition rules are met); this includes removal of the “Create categories if they do not exist” from the mapping screen;
    • made it possible to import existing categories into a categories field which has custom source selected
  • entries field => the field can have multiple sources selected, including custom ones; in this PR I have:
    • made it possible to import entries into an entries field that has a custom source selected
    • disabled creating new entries if the only selected sources are custom ones (because of ensuring all the condition rules are met); this includes removal of the “Create entries if they do not exist” from the mapping screen;
  • tags field => n/a; there is no area to create custom sources for tags
  • users field => same as with entries

Related issues

#1488

@i-just i-just marked this pull request as ready for review September 3, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant