Add gradio UI #11
Merged
Add gradio UI #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reuben
reviewed
Dec 11, 2023
| cloned_speakers = {} | ||
|
|
||
| print("Preparing file structure...") | ||
| if not os.path.exists(OUTPUT): |
There was a problem hiding this comment.
Better to use os.makedirs(..., exist_ok=True), that way the folder structure is also repaired if it's incomplete.
reuben
reviewed
Dec 11, 2023
|
|
||
| print("Preparing file structure...") | ||
| if not os.path.exists(OUTPUT): | ||
| os.mkdir(OUTPUT) |
There was a problem hiding this comment.
Side effects should never run top-level, always be contained inside an if __name__ == '__main__': block.
There was a problem hiding this comment.
Yeah but I couldn't make it work, here I define STUDIO_SPEAKERS for example that I use below, if I move it in the if main I get NameError: name 'STUDIO_SPEAKERS' is not defined. Maybe we can update in the next PR?
reuben
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.