Load the japanese phonemizer only if there's an environment variable set #2826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The environment variable ENABLE_JAPANESE should exist for the ja_jp_phonemizer to be available
|
|
Bug fix
Fix mecab dependency
Update GitHub actions
erogol
requested changes
Aug 4, 2023
| @@ -2,11 +2,20 @@ | |||
| from TTS.tts.utils.text.phonemizers.base import BasePhonemizer | |||
| from TTS.tts.utils.text.phonemizers.espeak_wrapper import ESpeak | |||
| from TTS.tts.utils.text.phonemizers.gruut_wrapper import Gruut | |||
| from TTS.tts.utils.text.phonemizers.ja_jp_phonemizer import JA_JP_Phonemizer | |||
| import os | |||
| if "ENABLE_JAPANESE" in os.environ: | |||
There was a problem hiding this comment.
I think we can easily try-catch the import and show a warning if the user wants to use JA but it is not installed. ENV variable is not necessary as we already expect you to show your intentions when you install TTS with pip install TTS[ja]
|
Fixed the problem here #2843 Closing it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After installing TTS using the following command
this fails
with the following error:
This fix expects the user to set an environment value to work with Japanese. The environment variable ENABLE_JAPANESE should exist for the ja_jp_phonemizer to be available.