Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Percival #255

Merged
merged 2 commits into from
Aug 3, 2024
Merged

Add Percival #255

merged 2 commits into from
Aug 3, 2024

Conversation

ocots
Copy link
Member

@ocots ocots commented Jul 30, 2024

No description provided.

@ocots ocots linked an issue Jul 30, 2024 that may be closed by this pull request
Copy link
Member

@jbcaillau jbcaillau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocots nice to have added Percival in the doc 👍🏽

@@ -48,22 +59,28 @@ You can extract this raw NLP problem with the [`get_nlp`](@ref) method.
nlp = get_nlp(docp)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocots this syntax has been changed in CTDirect 0.10 (and will be in OptimalControl next release) ; @PierreMartinon do you confirm it should be docp, nlp = direct_transcription(...)?

Copy link
Member Author

@ocots ocots Jul 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. @PierreMartinon has already changed this file. We will have to merge both updates.

@ocots
Copy link
Member Author

ocots commented Jul 31, 2024

@ocots nice to have added Percival in the doc 👍🏽

Yes but it does not seem to work well. I have used the solution from ipopt as initial guess but no improvement compared to default initial guess.

@PierreMartinon
Copy link
Member

@ocots maybe we merge this one first then update the 0.10.0 one ?

@ocots
Copy link
Member Author

ocots commented Jul 31, 2024

As you want. I can also update it later.

@PierreMartinon
Copy link
Member

As you want. I can also update it later.

Done. All yours :D

@jbcaillau
Copy link
Member

jbcaillau commented Jul 31, 2024

@ocots are you waiting to solve the conflicts below to release 0.10.0?

@ocots
Copy link
Member Author

ocots commented Aug 1, 2024

@jbcaillau No I am just waiting to dry 🏖

@jbcaillau
Copy link
Member

jbcaillau commented Aug 1, 2024

@jbcaillau No I am just waiting to dry 🏖

@ocots while you're drying 🙂 #251 (comment)

@jbcaillau
Copy link
Member

@PierreMartinon @ocots guys, can you please resolve and merge? I'm stuck in #257 seemingly because of this:

@ Documenter ~/.julia/packages/Documenter/qoyeC/src/utilities/utilities.jl:46
┌ Error: failed to run `@example` block in src/tutorial-nlp.md:39-42```@example main
│ docp, nlp = direct_transcription(ocp)
│ nothing # hide
```
│   exception =
│    MethodError: no method matching iterate(::DOCP)

@ocots
Copy link
Member Author

ocots commented Aug 2, 2024

Ok I do it asap.

@PierreMartinon
Copy link
Member

PierreMartinon commented Aug 3, 2024

I fixed the tutorial conflict (2 calls to get_nlp removed)
By the way, I can look into having percival as a solver option for CTDirect. This would be a package extension as for ipopt. Ideally we would tailor the error message for missing packages (eg 'Please execute use NLPModelsIpopt / Percival(?)' when nlp_solver = ipopt / percival etc), cf the error types discussion.

@PierreMartinon PierreMartinon merged commit f7abf6c into main Aug 3, 2024
2 checks passed
@PierreMartinon PierreMartinon deleted the 222-manipulation-of-the-nlp branch August 3, 2024 07:11
@ocots
Copy link
Member Author

ocots commented Aug 3, 2024

I fixed the tutorial conflict (2 calls to get_nlp removed) By the way, I can look into having percival as a solver option for CTDirect. This would be a package extension as for ipopt. Ideally we would tailor the error message for missing packages (eg 'Please execute use NLPModelsIpopt / Percival(?)' when nlp_solver = ipopt / percival etc), cf the error types discussion.

Could be nice. Have you seen that it does not perform well on the example?

@PierreMartinon
Copy link
Member

Not yet, I'll try the small benchmark series

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manipulation of the NLP
3 participants