consider extradata and showFields settings #417
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThibautBorn
force-pushed
the
improve_data_serializing
branch
2 times, most recently
from
7395836
to
6ca1a22
Compare
|
My first reaction is that this seems quite some change. Can you add some tests to cover those changes ? |
context: Without checking the extradata and showFields options of the save action, a lot of valid data wasn't (de)serialized
context: test with extradata and showfields
ThibautBorn
force-pushed
the
improve_data_serializing
branch
from
6ca1a22
to
d8606c5
Compare
|
Will bring it back in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context: Without checking the extradata and showFields options of the save action, a lot of valid data wasn't (de)serialized