Make R2 Object::size return u64 #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kflansburg
approved these changes
Aug 27, 2024
thibmeu
pushed a commit
to thibmeu/workers-rs
that referenced
this pull request
Sep 2, 2024
Co-authored-by: Lane Kolbly <[email protected]>
renovate bot
added a commit
to spiraldb/vortex
that referenced
this pull request
Sep 13, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [worker](https://redirect.github.com/cloudflare/workers-rs) | workspace.dependencies | minor | `0.3.0` -> `0.4.0` | --- ### Release Notes <details> <summary>cloudflare/workers-rs (worker)</summary> ### [`v0.4.0`](https://redirect.github.com/cloudflare/workers-rs/releases/tag/v0.4.0) [Compare Source](https://redirect.github.com/cloudflare/workers-rs/compare/v0.3.4...v0.4.0) #### What's Changed - Relax type of callback arguments to `Router` methods. This uses APIT to allow more types than a function pointer to implement handlers (i.e. async closure) by [@​compiler-errors](https://redirect.github.com/compiler-errors) in [cloudflare/workers-rs#605 - Fix typos in CORS argument names by [@​OliverEvans96](https://redirect.github.com/OliverEvans96) in [cloudflare/workers-rs#629 - Implement `get_all` function to return non-folding set-cookie headers by [@​nakamura-shuta](https://redirect.github.com/nakamura-shuta) in [cloudflare/workers-rs#597 - Add `FormData` conversion into `JsValue` by [@​thibmeu](https://redirect.github.com/thibmeu) in [cloudflare/workers-rs#634 > \[!CAUTION] > Breaking: Make R2 `Object::size` return `u64` by [@​lkolbly](https://redirect.github.com/lkolbly) in [cloudflare/workers-rs#625 #### New Contributors - [@​lkolbly](https://redirect.github.com/lkolbly) made their first contribution in [cloudflare/workers-rs#625 - [@​compiler-errors](https://redirect.github.com/compiler-errors) made their first contribution in [cloudflare/workers-rs#605 - [@​OliverEvans96](https://redirect.github.com/OliverEvans96) made their first contribution in [cloudflare/workers-rs#629 - [@​nakamura-shuta](https://redirect.github.com/nakamura-shuta) made their first contribution in [cloudflare/workers-rs#597 - [@​thibmeu](https://redirect.github.com/thibmeu) made their first contribution in [cloudflare/workers-rs#634 **Full Changelog**: cloudflare/workers-rs@v0.3.4...v0.4.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/spiraldb/vortex). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC43NC4xIiwidXBkYXRlZEluVmVyIjoiMzguNzQuMSIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AiLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
Object::size()returnu64, in case the R2 object is larger than 2^32 bits.Tested using an object that was smaller than 2^32 that the type conversion was successful.