Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ceph fixes 2 #172

Open
wants to merge 2 commits into
base: cernbox
Choose a base branch
from
Open

Ceph fixes 2 #172

wants to merge 2 commits into from
+20 −15

Conversation

javfg
Copy link

@javfg javfg commented Nov 9, 2023

This PR fixes the problem we encountered where the web calls an endpoint in reva which will always return 404.

It also reorders the Ceph entry in the sidebar as @glpatcern suggested.

glpatcern
glpatcern approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart a cosmetic change, all good for me. Clearly the question is how this patch gets folded into the webmerge project, and whether the WinSpaces entry must become an extension.

packages/web-app-files/src/index.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glpatcern glpatcern glpatcern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@javfg @glpatcern