Code and lambda functions refactored. cdk-patterns#166

cdktemp · Jan 12, 2021 · 816f153 · 816f153
1 parent f487173
commit 816f153
Show file tree

Hide file tree

Showing 5 changed files with 71 additions and 313 deletions.
diff --git a/the-alexa-skill/python/lambda_fns/lambda.js b/the-alexa-skill/python/lambda_fns/lambda.js
diff --git a/the-alexa-skill/python/lambda_fns/lambda.ts b/the-alexa-skill/python/lambda_fns/lambda.ts
diff --git a/the-alexa-skill/python/lambda_fns/package.json b/the-alexa-skill/python/lambda_fns/package.json
diff --git a/the-alexa-skill/python/the_alexa_skill/the_alexa_skill_stack.py b/the-alexa-skill/python/the_alexa_skill/the_alexa_skill_stack.py
@@ -46,11 +46,7 @@ def __init__(self, scope: core.Construct, id: str, **kwargs) -> None:
                                       removal_policy=core.RemovalPolicy.DESTROY
                                       )
 
-        # install node dependencies for lambdas
-        lambda_folder = os.path.dirname(os.path.realpath(__file__)) + "/../lambda_fns"
-        subprocess.check_call("npm i".split(), cwd=lambda_folder, stdout=subprocess.DEVNULL)
-        subprocess.check_call("npm run build".split(), cwd=lambda_folder, stdout=subprocess.DEVNULL)
-
+        # Lambda function for Alexa fulfillment
         alexa_lambda = _lambda.Function(self, "AlexaLambdaHandler",
                                         runtime=_lambda.Runtime.NODEJS_12_X,
                                         code=_lambda.Code.from_asset("lambda_fns"),

diff --git a/the-alexa-skill/typescript/lib/the-alexa-skill-stack.ts b/the-alexa-skill/typescript/lib/the-alexa-skill-stack.ts
@@ -38,13 +38,10 @@ export class TheAlexaSkillStack extends cdk.Stack {
       removalPolicy: cdk.RemovalPolicy.DESTROY
     });
 
-    // Install Dependencies and Compile Lambda Function
-    execSync('cd lambda-fns && npm i && npm run build');
-
     // Lambda function for Alexa fulfillment
     const alexaLambda = new lambda.Function(this, 'AlexaLambdaHandler', {
       runtime: lambda.Runtime.NODEJS_12_X,
-      code: lambda.Code.asset('lambda-fns'),
+      code: lambda.Code.fromAsset('lambda-fns'),
       handler: 'lambda.handler',
       environment: {
         USERS_TABLE: usersTable.tableName