Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tf2_eigen compilation issues #709

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

FelipeGdM
Copy link
Contributor

@FelipeGdM FelipeGdM commented Nov 20, 2023

When trying to compile the master branch, the following error is raised

--- stderr: pcl_recorder                                
In file included from /home/felipe/Documents/Github/carla_ws/src/ros-bridge/pcl_recorder/src/mainROS2.cpp:7:
/home/felipe/Documents/Github/carla_ws/src/ros-bridge/pcl_recorder/include/PclRecorderROS2.h:13:10: fatal error: tf2_eigen/tf2_eigen.h: No such file or directory
   13 | #include <tf2_eigen/tf2_eigen.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
gmake[2]: *** [CMakeFiles/pcl_recorder_node.dir/build.make:90: CMakeFiles/pcl_recorder_node.dir/src/mainROS2.cpp.o] Error 1
gmake[2]: *** Waiting for unfinished jobs....
In file included from /home/felipe/Documents/Github/carla_ws/src/ros-bridge/pcl_recorder/src/PclRecorderROS2.cpp:13:
/home/felipe/Documents/Github/carla_ws/src/ros-bridge/pcl_recorder/include/PclRecorderROS2.h:13:10: fatal error: tf2_eigen/tf2_eigen.h: No such file or directory
   13 | #include <tf2_eigen/tf2_eigen.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

This can be fixed by adding tf2_eigen as dependency in CMakeLists.txt

This error is likely caused by a change in dependencies relationship whitin pcl_recorder target dependecies. For example, pcl_recorder depends in A and A depends on tf2_eigen, so tf2_eigen is imported as a dependency to pcl_recorder as well. For some unknown reason, A doesn't import tf2_eigen as dependency anymore, so pcl_recorder has a missing depency, as it uses tf2_eigen directly but doesn't lists as a dependency.


This change is Reviewable

@brew0722
Copy link

+1: I had a same issue on ubuntu 22.04, and It's solved with this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants