Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve erf/expm1/expint coverage. #1111

Open
wants to merge 29 commits into
base: develop
Choose a base branch
from
Open

Conversation

jzmaddock
Copy link
Collaborator

In the expm1 case, tighten up error handling and testing.

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 99.33775% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.36%. Comparing base (5459e14) to head (ba6838c).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1111      +/-   ##
===========================================
+ Coverage    93.77%   94.36%   +0.58%     
===========================================
  Files          772      774       +2     
  Lines        61352    59754    -1598     
===========================================
- Hits         57535    56386    -1149     
+ Misses        3817     3368     -449     
Files Coverage Δ
.../boost/math/special_functions/detail/bessel_ik.hpp 100.00% <100.00%> (ø)
.../boost/math/special_functions/detail/bessel_j1.hpp 100.00% <ø> (ø)
.../boost/math/special_functions/detail/bessel_k0.hpp 100.00% <ø> (ø)
.../boost/math/special_functions/detail/bessel_k1.hpp 100.00% <ø> (ø)
...ost/math/special_functions/detail/igamma_large.hpp 100.00% <ø> (+66.88%) ⬆️
...ost/math/special_functions/detail/lgamma_small.hpp 100.00% <100.00%> (+40.63%) ⬆️
.../boost/math/special_functions/detail/polygamma.hpp 91.38% <ø> (-0.64%) ⬇️
...h/special_functions/detail/unchecked_factorial.hpp 99.10% <ø> (-0.90%) ⬇️
include/boost/math/special_functions/erf.hpp 100.00% <ø> (+0.45%) ⬆️
include/boost/math/special_functions/expint.hpp 100.00% <ø> (+2.03%) ⬆️
... and 29 more

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5459e14...ba6838c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant