TryFromJs
from JsMap
for HashMap
& BtreeMap
#3998
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like
TryFromJs
didn't convert correctly fromJsMap
intoHashMap
/BtreeMap
This PR fix it
Example
Next code
before this changes will return:
and after changes returns:
Notes
I don't find more fast way(than the one used in
for_each_elem_in_js_map
) to get(key, value)
's fromJsMap
.Maybe there is a way?
Or maybe I should write it (for example by function like next but that just return
Option<(JsValue, JsValue)>
)?