Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement register allocation #3942

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Implement register allocation #3942

merged 3 commits into from
Sep 12, 2024

Conversation

HalidOdat
Copy link
Member

As discussed in #3194 this PR extracts the register allocation logic from #3798 which will be used by both PRs.

@HalidOdat HalidOdat added execution Issues or PRs related to code execution vm Issues and PRs related to the Boa Virtual Machine. labels Aug 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 3, 2024 •
edited
Loading

Test262 conformance changes

Test result main count PR count difference
Total 48,494 48,494 0
Passed 43,609 43,609 0
Ignored 1,500 1,500 0
Failed 3,385 3,385 0
Panics 0 0 0
Conformance 89.93% 89.93% 0.00%

@HalidOdat HalidOdat requested a review from a team August 17, 2024 16:14
jedel1043
jedel1043 reviewed Aug 18, 2024
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some suggestions that could maybe improve the ergonomics of the register allocator API.

core/engine/src/bytecompiler/register.rs Outdated Show resolved Hide resolved
core/engine/src/bytecompiler/register.rs Outdated Show resolved Hide resolved
@raskad raskad mentioned this pull request Sep 7, 2024
Merged
@HalidOdat HalidOdat requested a review from a team September 11, 2024 12:49
@HalidOdat HalidOdat added this to the next-release milestone Sep 11, 2024
raskad
raskad requested changes Sep 11, 2024
View reviewed changes
Copy link
Member

@raskad raskad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just got one thing that caused panics.

core/engine/src/vm/opcode/rest_parameter/mod.rs Outdated Show resolved Hide resolved
@HalidOdat HalidOdat requested review from raskad and a team September 12, 2024 04:54
@raskad raskad requested a review from a team September 12, 2024 18:17
jedel1043
jedel1043 approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@raskad raskad added this pull request to the merge queue Sep 12, 2024
Merged via the queue into main with commit c480a42 Sep 12, 2024
13 checks passed
@raskad raskad deleted the register-alloc-logic branch September 12, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raskad raskad raskad approved these changes

@jedel1043 jedel1043 jedel1043 approved these changes

Assignees
No one assigned
Labels
execution Issues or PRs related to code execution vm Issues and PRs related to the Boa Virtual Machine.
Projects
None yet
Milestone
next-release
Development

Successfully merging this pull request may close these issues.
3 participants
@HalidOdat @raskad @jedel1043