Preferences caching #2792
Draft
Preferences caching #2792
+101
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinivy
reviewed
Sep 8, 2024
| repoRevCacheMaxTTL: envInt('PDS_REPO_REV_CACHE_MAX_TTL'), // milliseconds (use 0 to disable) | ||
| preferencesCacheMaxTTL: envInt('PDS_REPO_REV_CACHE_MAX_TTL'), // milliseconds (use 0 to disable) |
There was a problem hiding this comment.
Suggested change
| preferencesCacheMaxTTL: envInt('PDS_REPO_REV_CACHE_MAX_TTL'), // milliseconds (use 0 to disable) | |
| preferencesCacheMaxTTL: envInt('PDS_PREFS_CACHE_MAX_TTL'), // milliseconds (use 0 to disable) |
devinivy
reviewed
Sep 8, 2024
Comment on lines
+11
to
+18
| const cachedPrefs = await ctx.preferencesCache?.get(requester) | ||
| if (cachedPrefs) { | ||
| const preferences = JSON.parse(cachedPrefs) | ||
| return { | ||
| encoding: 'application/json', | ||
| body: { preferences }, | ||
| } | ||
| } |
There was a problem hiding this comment.
We still want to apply the scope here.
devinivy
reviewed
Sep 8, 2024
Comment on lines
+30
to
+33
| await ctx.preferencesCache?.set( | ||
| requester, | ||
| JSON.stringify(checkedPreferences), | ||
| ) |
There was a problem hiding this comment.
I believe this could cache different contents depending on the user's scope. Maybe it would be more straightforward to control the cache contents entirely on the read path as a read-through cache, and turn this into an invalidation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.