Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change max length of names to 64 graphemes #2628

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

haileyok
Copy link
Member

@haileyok haileyok commented Jul 7, 2024

Why

Something that got surfaced by starter packs is that lists currently allow only 64 utf-8 bytes, not 64 graphemes. This is extremely restrictive, especially for foreign languages which use non-roman alphabets. For example, just adding the word hello to a list name (i.e. こんにちは) takes up 15 bytes.

I think bumping this to what I suspect is the intended max limit should be okay, since any previously created list should already be compliant with this. One thing to note of course would be that existing clients would maybe have problems when receiving a response that includes a starter pack with a longer name. At least for us, we could OTA something to the past few versions to help ease that concern.

Copy link
Collaborator

@bnewbold bnewbold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels good and comfy to me. I would guess these values were mostly copypasta between Lexicons and should have been 64 graphemes from the start.

In terms of roll-out, I think doing everything but PDS for a week, then rolling out to PDS, is what would go easiest. Not sure how hard that would be to coordinate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants