Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allows user to freeze and unfreeze a column for horizontal scroll. #2310

Merged
merged 18 commits into from
Sep 19, 2024
Merged

Allows user to freeze and unfreeze a column for horizontal scroll. #2310

merged 18 commits into from
Sep 19, 2024

Conversation

deepakjosp
Copy link
Contributor

@deepakjosp deepakjosp commented Sep 13, 2024 •
edited
Loading

Fixes #2294

Description

  • Implements freeze/unfreeze column feature in the Table.

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added proper data-cy and data-testid attributes.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@deepakjosp
Added freeze/unfreeze column to the column header menu.
15a5bf4
@deepakjosp
Created the handler to freeze and sort the frozen columns so that the…
d82a581 
… frozen columns will be on the left hand side.
@deepakjosp
Passed down the prop onColumnFreeze.
d7e77aa
@deepakjosp
Fixed the more menu visible on the checkbox column.
6318c43
@deepakjosp
Moved the columnFreeze handler to useColumn hook.
6afc7ef
@deepakjosp
Set the value of fixed in the col in useResizable col hook.
aea2c32
@deepakjosp
Sorted the column based on the fixed value.
3c711b1
@deepakjosp
Modified the HeaderCellMenu to render the menu text based on the colu…
c2123a2 
…mn status set from the useReizeableColumn hook.
@deepakjosp
Copied the useLocalStorage hook and it's dependent util functions fro…
8219dd7 
…m commons-frontend to neetoui.
@deepakjosp
Created a util function to consistently generate a unique id from the…
fed0216 
… url pathname and set it as the prefix of the localstorage key.
@deepakjosp
Refacored the onColumnFreeze callback to not depend on the columndata.
644e2a7
@deepakjosp
Cleaned up the column data memoization.
145ce71
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-kpyu-pr-2310 September 13, 2024 10:16 Inactive
@deepakjosp deepakjosp self-assigned this Sep 13, 2024
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-kpyu-pr-2310 September 13, 2024 10:29 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-kpyu-pr-2310 September 13, 2024 11:34 Inactive
@deepakjosp deepakjosp added patch Releases small requests or bug fixes. labels Sep 13, 2024
@deepakjosp
Copy link
Contributor Author

@josephmathew900 _a please review. There's a know bug within NeetoForm responses table. I've created an issue for that.

@neetogit-bot neetogit-bot bot assigned josephmathew900 and unassigned deepakjosp Sep 13, 2024
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-kpyu-pr-2310 September 18, 2024 03:24 Inactive
josephmathew900
josephmathew900 reviewed Sep 18, 2024
View reviewed changes
Copy link
Contributor

@josephmathew900 josephmathew900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deepakjosp _a https://joseph-mathew.neetorecord.com/watch/ce740f24-2f41-4255-8fef-b063521c1382

@neetogit-bot neetogit-bot bot assigned deepakjosp and unassigned josephmathew900 Sep 18, 2024
@deepakjosp
Fixed unfrozen column getting freeze after UI resize.
bd94279
@deepakjosp
Merge branch '2294-allow-user-to-freezeunfreeze-a-column-for-horizont…
90884e4 
…al-scroll' of github.com:bigbinary/neeto-ui into 2294-allow-user-to-freezeunfreeze-a-column-for-horizontal-scroll
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-kpyu-pr-2310 September 18, 2024 05:46 Inactive
@josephmathew900
Copy link
Contributor

@deepakjosp Code changes LGTM. I have tested the issue with viewport resize and it is working fine now. The only issue remaining is with column jumping when freezing and unfreezing a column.

@deepakjosp
Copy link
Contributor Author

@josephmathew900 the UI glitch is because of the inline style set to the CellContent component. I've created an issue to debug and fix the issue in NeetoUI. Let's merge this PR.

@deepakjosp deepakjosp merged commit 7106c87 into main Sep 19, 2024
1 check passed
@deepakjosp deepakjosp deleted the 2294-allow-user-to-freezeunfreeze-a-column-for-horizontal-scroll branch September 19, 2024 06:10
josephmathew900
josephmathew900 approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@josephmathew900 josephmathew900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephmathew900 josephmathew900 josephmathew900 approved these changes

Assignees

@deepakjosp deepakjosp

Labels
patch Releases small requests or bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow user to freeze/unfreeze a column for horizontal scroll
2 participants
@deepakjosp @josephmathew900