This repository has been archived by the owner on Feb 9, 2022. It is now read-only.
breakout logic into its own module #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 23, 2014 20:56
This change allows you to specify options to applied to multiple targets:
```js
umd: {
options: {
template: 'path/to/template'
},
main: {
src: 'path/to/src',
dest: 'path/to/dest'
},
alternate: {
src: 'path/to/src',
dest: 'path/to/dest'
}
}
```
This change is backwards-compatible with older versions of `grunt-umd`. The only caveat is that anything in `options` will overwrite anything in the root `data` object.
Updated `README.md` to reflect new usage.
Udpated `package.json` to bump minor version. Added yours truly to `contributors`.
|
Ok. I merged #19. Go ahead with the cherrypick. After that I'll push the separated module to a npm module of its own and make the plugin to depend on that. And finally we should get a new version of I know lack of unit tests is worrying. Ideally there would be an executable specification or something like that. It would be even better to include the library at https://github.com/umdjs . See umdjs/umd#42 . |
bebraw
added a commit
that referenced
this pull request
Oct 26, 2014
Breakout logic into its own module
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #19. Once #19 is merged in, I'll cherry-pick 8ed832d on top of it.
In #17, it was mentioned that breaking out the logic into its own module might be a good idea. I agreed, and thought it wouldn't take too long, and it didn't, so here it is.
Feel free to take
umd-templateandnpm publishit or whatever. If you wish, I can do this, then either rewrite this PR to require the published module or provide a new PR.This is more exploratory than anything, because:
I ran the demo against it and it seemed to work, but your mileage may vary. Let me know what you think.