Update development.md #156
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aya-rs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alessandrod
reviewed
Apr 30, 2024
docs/book/start/development.md
Outdated
| @@ -35,7 +35,7 @@ cargo install cargo-generate | |||
| ``` | |||
|
|
|||
| And finally to generate bindings for kernel data structures, you must install | |||
| `bpftool`, either from your distribution or building it from | |||
| `bpftool`. This tool is part of the package `linux-tools-common`, `linux-lowlatency-tools-common` or you can build it from | |||
There was a problem hiding this comment.
These names are unlikely to be the same across distros? Also IIRC linux-tools-common under ubuntu installs a stub that when executed tells you "you need to install linux-tools-" or something like that
There was a problem hiding this comment.
You're right but it was not clear for me,btw I rewrite it
alessandrod
reviewed
Apr 30, 2024
docs/book/start/development.md
Outdated
| And finally to generate bindings for kernel data structures, you must install | ||
| `bpftool`, either from your distribution or building it from | ||
| [source](https://github.com/libbpf/bpftool). | ||
| To generate bindings for kernel data structures, you'll need to install bpftool. You can locate this tool as part of a larger tools package in certain distributions (e.g., `linux-tools-common` on Ubuntu), or you can opt to build it from its [source](https://github.com/libbpf/bpftool). |
There was a problem hiding this comment.
I'd say
To generate bindings for kernel types you need to install bpftool. You can install it from your
distribution (run `sudo apt install linux-tools-$(uname -r)` under debian based distributions), or
building from [source])(https://github.com/libbpf/bpftool).
tamird
requested changes
Jul 30, 2024
|
+1 to what Tamir said. Bear in mind on Fedora |
|
No problem! It was the only unclear step for me, but most likely the problem is me 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.