Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused code in elm-format-lib #812

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

8n8
Copy link
Contributor

@8n8 8n8 commented Apr 1, 2023

Removed some unused code.

@avh4 avh4 added this to the 0.8.7 milestone Apr 1, 2023
-- in
-- do touchForeignPtr fptr
-- return result

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will eventually be needed; ideally https://github.com/avh4/elm-format/blob/main/elm-format-lib/src/ElmFormat/Parse.hs#L22 will change to take ByteString instead of Text, and https://github.com/avh4/elm-format/blob/aded67fb5db42afd17bfa372eab23f8a01cb635d/elm-format-lib/src/Parse/Parse.hs will change to take ByteString instead of String.

Sorry things are a bit of a mess atm.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specifically, #301 is the blocking issue for the above mentioned ideal changes.

@@ -58,11 +57,6 @@ instance Coapplicative Located where
{-# INLINE extract #-}


traverse :: (Functor f) => (a -> f b) -> Located a -> f (Located b)
traverse func (At region value) =
At region <$> func value
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little hesitant to remove, as it might be useful for some upcoming features. Though maybe this should be moved to a Traversable instance?

@avh4 avh4 modified the milestones: 0.8.7, 0.10.0 Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants