New Github action added for cli #1487
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
@asyncapi/bounty_team |
github-action/lib/index.js
Outdated
There was a problem hiding this comment.
@akshatnema this has been already changed and we are using bash script right now.
There was a problem hiding this comment.
So, it's not needed in action, now right?
There was a problem hiding this comment.
Yeah, you have to add the bash script.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| # Create a non-root user | ||
| RUN addgroup -S myuser && adduser -S myuser -G myuser | ||
|
|
||
| RUN apk add --no-cache bash>5.1.16 git>2.42.0 chromium |
Check notice
Code scanning / SonarCloud
Arguments in long RUN instructions should be sorted Low
|
/u |
|
@akshatnema any blockers being faced by you? |
|
|
There is no update as I'm researching around the fact on how to manage GitHub Action for CLI. @Shurtu-gal and @derberg proposals require different configurations, which in fact means we need to have the same package.json for both CLI and it's respective GitHub action. I'm currently looking at how to use only one configuration and one package.json. Although the matter looks simple, it will take time to try different approaches, so if I don't achieve a break-through in the nearest couple of days, I'll ask for the Timeline Extension. |
|
but the GH action do not need package.json as it is bash and docker based only. So no need for monorepo afaik - I think we talked about it |
|
@derberg @Shurtu-gal ok so should we do it in a manner that we completely remove the package.json from github action? Since, there is no need of a separate package.json, our whole github action depends on the working of |
That's correct. If I remember correctly the package.json was there just to support the workflows already present. |
Description
Draft PR to add the github action for cli from https://github.com/asyncapi/github-action-for-cli.
Related issue(s)
asyncapi/github-action-for-cli#396