Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PyAutoLens as AstroPy Affiliated Package #492

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Jammy2211
Copy link

We are requesting affiliated status for our package PyAutoLens :).

Copy link
Contributor

@dhomeier dhomeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for proposing this package as an affiliated package to the Astropy project. I am presently searching for a reviewer to provide a detailed review; in the meantime I am only asking to make the suggested formal/formatting adjustments to the registry.

Comment on lines 9 to 10
"pypi_name": "https://pypi.org/project/autolens/",
"description": "Analysis, modeling and simulations of strong gravitational lenses.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"pypi_name": "https://pypi.org/project/autolens/",
"description": "Analysis, modeling and simulations of strong gravitational lenses.",
"pypi_name": "autolens",
"description": "Analysis, modeling and simulations of strong gravitational lenses.",
"coordinated": false,

Only use "project" name on PyPI; + required field.

@dhomeier
Copy link
Contributor

dhomeier commented Jul 1, 2022

Apologies for the delay as it took some time to find a referee familiar with this field of research. I am however happy to confirm that your package is now under review and we'll post the results of the review here and on the mailing list.
In the meantime I would merely suggest that you add a CITATION file to the main repo containing the principal information of the Citations section in your docs on how to cite your package, so it would be more visible to users of the package.

@Jammy2211
Copy link
Author

Apologies for the delay as it took some time to find a referee familiar with this field of research. I am however happy to confirm that your package is now under review and we'll post the results of the review here and on the mailing list. In the meantime I would merely suggest that you add a CITATION file to the main repo containing the principal information of the Citations section in your docs on how to cite your package, so it would be more visible to users of the package.

Excellent thank you!

We have a citations section on our docs (https://pyautolens.readthedocs.io/en/latest/general/citations.html) but will also add a CITATION file as all visibility is good visibilitiy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants