Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[red-knot] Infer target types for unpacked tuple assignment #13316

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dhruvmanila
Copy link
Member

Summary

Test Plan

@dhruvmanila dhruvmanila added the red-knot Multi-file analysis & type inference label Sep 10, 2024
@dhruvmanila
Copy link
Member Author

There's some more work needs to be done, please don't look ;)

Copy link
Contributor

github-actions bot commented Sep 10, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@dhruvmanila
Copy link
Member Author

This is completely an incorrect solution, I quickly realize that this will require structural matching between the target expression and the value type. It would also be good to add caching here because we've definitions for each name node on the LHS and so we'd perform structural matching against the same target and value type for each name node that's present on the LHS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
red-knot Multi-file analysis & type inference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant