Remove eAnalogReference from ArduinoCore-samd #718
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved to ArduinoCore-API and renamed to AnalogReference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the header for
analogReference(...)is defined in ArduinoCore-API (api/Common.h).My proposal is to move this enum to ArduinoCore-API and align the naming to the scheme that is used there.
This comes with the additional benefit of fixing a bug where the header that is defined over at
ArduinoCore-APItakesuint8_tas argument type, which leads to a compilation warning when compiling together withArduinoCore-samd.I filed a corresponding PR there too:
arduino/ArduinoCore-API#236
This unfortunately breaks a lot of the sketches as the corresponding change has not yet landed in ArduinoCore-API.