Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade create-starknet to latest version #488

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

BDCoy
Copy link

@BDCoy BDCoy commented Aug 23, 2024

Issue #481
This update addresses Issue #481, which required updating the create-starknet package to use Starknet React v3.

Solution

  • Updated the package build system to align with the core package (tsup).
  • Updated the templates to create projects that use Starknet React v3, updating the following versions in each project:

"@starknet-react/chains": "^3.0.0-beta.2",
"@starknet-react/core": "^3.0.0-beta.2",
"get-starknet-core": "^3.3.3",
"starknet": "^6.11.0"

  • Verified that no breaking changes were introduced.
  • Performed a complete test locally on Next.js and Vite projects to ensure compatibility, including testing wallet connections with Argent and Braavos.

@BDCoy BDCoy requested a review from fracek as a code owner August 23, 2024 16:38
@fracek
Copy link
Contributor

fracek commented Aug 25, 2024

Looks good, I made some minor comments. You should also add the project to pnpm-workspace.yaml

@BDCoy
Copy link
Author

BDCoy commented Aug 26, 2024

Hey @fracek,

I was able to update the branch with your comments. I also ran pnpm install-build and updated tsup to version "^8.0.2" to avoid deprecated warnings.

@fracek
Copy link
Contributor

fracek commented Aug 27, 2024

Looks like you need to run pnpm lint:fix

Copy link
Contributor

@fracek fracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now! Thank you

@fracek fracek merged commit 1f3563f into apibara:main Aug 29, 2024
1 check passed
@BDCoy
Copy link
Author

BDCoy commented Aug 29, 2024

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants