Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8712] Set namesrvAddrChoosed to null if choosed addr is not exist. #8713

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

qianye1001
Copy link
Contributor

…ient is no longer in use, a new channel connection will be created.

Which Issue(s) This PR Fixes

Fixes #8712

Brief Description

How Did You Test This Change?

…ient is no longer in use, a new channel connection will be created.
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.44%. Comparing base (280804c) to head (7784631).

Files with missing lines Patch % Lines
...e/rocketmq/remoting/netty/NettyRemotingClient.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8713      +/-   ##
=============================================
- Coverage      47.46%   47.44%   -0.03%     
+ Complexity     11543    11527      -16     
=============================================
  Files           1278     1278              
  Lines          89524    89524              
  Branches       11509    11509              
=============================================
- Hits           42496    42472      -24     
- Misses         41805    41822      +17     
- Partials        5223     5230       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fuyou001

This comment was marked as outdated.

Copy link
Contributor

@fuyou001 fuyou001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR need

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Ensure that when selected Namesrv addr is no longer in use, a new channel will be created.
3 participants