Use a random ${test:logging.path}
#2954
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `@TempLoggingDir` JUnit 5 extensions create a totally deterministic directory to hold the log files for tests. Since the directory is deleted only if all the tests succeed, this causes a problem with test reruns.
vy
reviewed
Sep 17, 2024
| @@ -51,7 +51,8 @@ public void beforeAll(ExtensionContext context) throws Exception { | |||
| Path loggingPath = null; | |||
| for (final Field field : fields) { | |||
| if (loggingPath != null) { | |||
| StatusLogger.getLogger().warn("Multiple fields with @TempLoggingDir annotation are not supported."); | |||
| StatusLogger.getLogger() | |||
| .warn("Multiple static fields with @TempLoggingDir annotation are not supported."); | |||
There was a problem hiding this comment.
If we're salting the generated paths, why not?
| @@ -78,7 +79,8 @@ public void beforeEach(ExtensionContext context) throws Exception { | |||
| final Object instance = context.getRequiredTestInstance(); | |||
| for (final Field field : fields) { | |||
| if (loggingPath != null) { | |||
| StatusLogger.getLogger().warn("Multiple fields with @TempLoggingDir annotation are not supported."); | |||
| StatusLogger.getLogger() | |||
| .warn("Multiple instance fields with @TempLoggingDir annotation are not supported."); | |||
| // Create a temporary directory that uses the simple class name as prefix | ||
| Path packagePath = basePath.resolve(dir); | ||
| Files.createDirectories(packagePath); | ||
| return Files.createTempDirectory(packagePath, clazz.getSimpleName()); |
There was a problem hiding this comment.
Can we suffix the path with something that will make directories lexicographically sorted by their creation time, please? For instance, timestamp + counter + salt, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@TempLoggingDirJUnit 5 extensions create a totally deterministic directory to hold the log files for tests.Since the directory is deleted only if all the tests succeed, this causes a problem with test reruns.