Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44114: [R] Add Rocky and opensuse to the allowlist for libarrow binaries #44124

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jonkeane
Copy link
Member

@jonkeane jonkeane commented Sep 15, 2024

Rationale for this change

Add two distros not checked on CRAN to our allow list for easier binary installs

What changes are included in this PR?

Added to distro names

Are these changes tested?

These configurations are tested elsewhere, the real test will come later if CRAN somehow runs these covertly

Are there any user-facing changes?

Faster, more reliably installs without intervention

@jonkeane jonkeane requested review from nealrichardson and removed request for assignUser September 15, 2024 13:24
Copy link

⚠️ GitHub issue #44114 has been automatically assigned in GitHub to PR creator.

@assignUser
Copy link
Member

Is there a reason to be specific with -leap? Or do we want just opensuse to be ok?

@jonkeane
Copy link
Member Author

Is there a reason to be specific with -leap? Or do we want just opensuse to be ok?

I discovered this when chatting with someone from the Posit Package Manager, and that's the string they got when they ran the distro code. But this might be an issue with distro, or maybe opensuse has different flavors? Or also possible that the Posit Package Manager folks are using a slightly non-standard build of opensuse. Do you know of any references for which to look for? I'm happy to add it, but I think we would need both to catch the system that they seem to be using.

@assignUser
Copy link
Member

I see but with any(grepl(paste(allowlist, collapse = "|"), os)) opensuse should cover opensuse-leap and any future versions if I'm not mistaken (not at a pc right now to test it^^)

@@ -222,7 +222,7 @@ check_allowlist <- function(os, allowed = "https://raw.githubusercontent.com/apa
# Try a remote allowlist so that we can add/remove without a release
suppressWarnings(readLines(allowed)),
# Fallback to default: allowed only on Ubuntu and CentOS/RHEL
error = function(e) c("ubuntu", "centos", "redhat", "rhel")
error = function(e) c("ubuntu", "centos", "redhat", "rhel", "rocky", "opensuse-leap")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recall the history on this, but the local copy of the allowlist should be present here, right? Can we fall back to readLines("nixlibs-allowlist.txt") (or whatever path it is relative to cwd)? That way we only have to track this in one place.

Also we should update the comment on the line above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants