Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-44066: [Python] Add Python wrapper for JsonExtensionType #44070

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

GH-44066: [Python] Add Python wrapper for JsonExtensionType #44070

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
61ae64f
Initial commit
rok Sep 11, 2024
64830a4
Apply suggestions from code review
rok Sep 12, 2024
52d089c
Review feedback
rok Sep 12, 2024
1d7a3f8
Set pa.json(storage_type=utf8())
rok Sep 12, 2024
0ca5a64
Review feedback
rok Sep 12, 2024
6b0a1e1
doctest fix
rok Sep 12, 2024
b176855
Rebase and enable casting for pa.string_view
rok Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions python/pyarrow/tests/test_extension_type.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1971,6 +1971,5 @@ def test_json(storage_type, pickle_module):
assert result == array

# cast extension type -> storage type
if storage_type != pa.string_view():
inner = array.cast(storage_type)
assert inner == storage
inner = array.cast(storage_type)
assert inner == storage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing that :)

Loading