Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
It seems that the usage of this dependency was removed in b7d2708, so we don't actually need it. Furthermore, even though it doesn't appear to be used anywhere else, just having the package as a dependency breaks `yarn build` on node 16: ``` yarn build yarn run v1.22.19 $ cross-env NODE_ENV=production webpack --hide-modules build [=== ] 15%Assertion failed: (thread_id_key != 0x7777), function find_thread_id_key, file coroutine.cc, line 134. error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. node:internal/process/promises:279 triggerUncaughtException(err, true /* fromPromise */); ^ RpcIpcMessagePortClosedError: Cannot send the message - the message port has been closed for the process 83355. at /Users/rmacklin/src/github.com/ankit/stylebot/stylebot/node_modules/fork-ts-checker-webpack-plugin/lib/rpc/rpc-ipc/RpcIpcMessagePort.js:47:47 at processTicksAndRejections (node:internal/process/task_queues:82:21) { code: undefined, signal: undefined } ``` and that `thread_id_key` error is apparently a well-known issue with the fibers package which doesn't support node 16: laverdet/node-fibers@8f28098 After removing the dependency, we can successfully run `yarn build` on node 16 (which is important, because earlier versions of node are not supported on darwin-arm64, a.k.a. Apple Silicon): ``` yarn build yarn run v1.22.19 $ cross-env NODE_ENV=production webpack --hide-modules build [====== ] 32%Browserslist: caniuse-lite is outdated. Please run: npx browserslist@latest --update-db Build completed in 5.822s ``` Co-authored-by: Ankit Ahuja <[email protected]>
- Loading branch information
