Clarify the reviewer window title #17106
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"1 day 2" seems really strange to me. "1 day 2 hours" would be too long for most smartphone. But "1 day 2h" seems reasonable to me Also, "plural" does not allow for two parameters, and it would have been complex to consider both words if they are singular or plural. Regarding "1 hour 5" I preferred to not change it. "1 hour 5 min" woud add far too many character. "1 hour 5m" sounds strange. And stating "1 hour 5" is far more standard than "1 day 5"
|
Message to maintainers, this PR contains strings changes.
Read more about updating strings on the wiki, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"1 day 2" seems really strange to me. "1 day 2 hours" would be too long for most smartphone. But "1 day 2h" seems reasonable to me
Also, "plural" does not allow for two parameters, and it would have been complex to consider both words if they are singular or plural.
Regarding "1 hour 5" I preferred to not change it. "1 hour 5 min" woud add far too many character. "1 hour 5m" sounds strange. And stating "1 hour 5" is far more standard than "1 day 5".
It seems I was the one who introduced this string in 2020. I have no idea why I had not put the "h" at the time. And I can't easily find the PR to see whether it was discussed at the time