"+n buried" becomes plurals
#17105
"+n buried" becomes plurals
#17105
Conversation
|
Message to maintainers, this PR contains strings changes.
Read more about updating strings on the wiki, |
Arthur-Milchior
force-pushed
the
plus_bury
branch
from
6b68c27
to
becf73f
Compare
| @@ -29,7 +29,9 @@ | |||
| <string name="send_feedback">Send feedback</string> | |||
|
|
|||
| <string name="studyoptions_start">Study</string> | |||
| <string name="studyoptions_buried_count">+%d buried</string> | |||
| <plurals name="studyoptions_buried_count"> | |||
| <item quantity="other"> +%d buried</item> | |||
There was a problem hiding this comment.
This seems unusual/incorrect: missing one.
Does this occur in our codebase previously, or is it allowed in the spec?
There was a problem hiding this comment.
As far as Android is concerned, this seems correct. I tested manually, and "other" is used in all missing cases.
There is no reason to add "one" in English when it's the same as English.
No, we never did it before.
I can add "one" if it reassures you.
|
I'd also propose moving it from "core". Non blocking and would be happy if this were in another PR/issue. Implementers choice |
|
I prefer to move it simultaneously. Because it'll require to retranslate the string, so let's just do it once |
In French, at least, the preterit differs depending on whether there is 1 or other value. So this need to be `plurals`. By the way, I'm not clear why this is considered core.
Arthur-Milchior
force-pushed
the
plus_bury
branch
from
becf73f
to
6cef7c7
Compare
In French, at least, the preterit differs depending on whether there is 1 or other value. So this need to be
plurals.By the way, I'm not clear why this is considered core.