Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to skip reindex #1584

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kshnurov
Copy link

searchkick triggers reindex on any change, including touch, but some fields (e.g. updated_at) may not be stored in index and there's no point in reindexing.

Current docs suggest manually defining callbacks, but that won't work with Searchkick.callbacks(:bulk) do, which will always trigger a reindex.

I've added a skip_searchkick_reindex? method which users may override to define their own logic.

@kshnurov
Copy link
Author

@ankane could you please review this?

@kshnurov
Copy link
Author

@ankane ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant