feat: use favicon_url instead of logo_url for favicon

[alex-lambdaloopers]

Hello everyone,

I recently started using sqladmin and I need to add a favicon.

I saw this merged PR #787 and I noticed that the same variable is used for both the logo and the favicon.

I updated the Admin definition so it accepts a favicon_url, and updated the base template.

Note: I followed the contribution guide, but have been unable to run the hatch commands locally. I am getting this error:

$ hatch run lint
/bin/sh: line 1: lint: command not found

I tried using other commands and subcommands (hatch run lint.check) but I get the same result.

Edit: I see the commands were successful on github actions

[CodeBooster97]

Yes, this makes sense.

[maxim-f1]

Hello everyone,

I recently started using sqladmin and I need to add a favicon.

I saw this merged PR #787 and I noticed that the same variable is used for both the logo and the favicon.

I updated the Admin definition so it accepts a favicon_url, and updated the base template.

Note: I followed the contribution guide, but have been unable to run the hatch commands locally. I am getting this error:

$ hatch run lint
/bin/sh: line 1: lint: command not found

I tried using other commands and subcommands (hatch run lint.check) but I get the same result.

Edit: I see the commands were successful on github actions

I'm facing the same problem. This command helped me

hatch run lint:check

[alex-lambdaloopers]

@maxim-f1 thanks, that was it

[aminalaee]

Thanks for the PR, looks good 👍