switch back to regular wiremock but with jetty12 support #1844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgalek
force-pushed
the
wiremock-jetty12
branch
from
85eece8
to
2831db5
Compare
bgalek
force-pushed
the
wiremock-jetty12
branch
from
2831db5
to
3f57fa2
Compare
|
Hey, thanks for the contribution! 🎉 It seems that after your change the unit tests are not passing, could you take a look at it? |
|
yeah, I'll look into that :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
hermes-mockwithwiremock-jetty12tests in such project will have problem choosing property wiremock version (since wiremock-standalone will be on their classpath).This should make builds faster and more accessible for people to use :)