resolve #1738 | Add jetty http client request processing time metrics #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkySurferOne
force-pushed
the
1738-improve-monitoring-http-serial-client
branch
from
fbbfbea
to
3f777ff
Compare
|
Not sure if tests are flaky or my code broke them. I'd be grateful for some guidance. Also please let me know if you want a test for that metrics are reported when they are turn on. |
szczygiel-m
previously approved these changes
Oct 19, 2023
|
@SkySurferOne I know I told you that we want these metrics for serial client, but I realised that batch |
|
When it comes to the failed test, these are flaky ones, we will fix them in a few weeks. By the time I'll rerun them until passed |
SkySurferOne
force-pushed
the
1738-improve-monitoring-http-serial-client
branch
from
244782e
to
8eca2b2
Compare
faderskd
previously approved these changes
Oct 20, 2023
szczygiel-m
previously approved these changes
Oct 23, 2023
SkySurferOne
dismissed stale reviews from szczygiel-m and faderskd
via
63d9ca9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.