Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cgo tvos and add module.modulemap for xcframeworks #37

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

InstaRobot
Copy link

This commit fixes the CGO build for tvOS and adds module.modulemap for correct library linking in the project.

@yiguous
Copy link
Collaborator

yiguous commented Aug 12, 2024

Thanks for contribution.
LibXray.xcframework does not contain module.modulemap is implemented on purpose. If there are two xcframeworks which contains module.modulemap in one Xcode project, the compilation will fail. For avoiding conflicts with other libraries, LibXray.xcframework won't include module.modulemap until Apple solves this problem.

So please remove the codes related module.modulemap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants