Change default port to 8900 #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port 7000 is occupied by default on macOS. This also makes it simpler how to customize it (use env var instead of hardcoded in the package.json) WebKit#325
maattdd
force-pushed
the
remove-port-7000
branch
from
04bb851
to
978cc8a
Compare
rniwa
approved these changes
Sep 9, 2024
|
FWIW, we should wait for approval from other browser vendors. |
|
should we also update the port when running speedometer in dev mode? https://github.com/WebKit/Speedometer/blob/main/package.json#L18-L19 |
The current patch changes both. (dev and server) |
flashdesignory
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port 7000 is occupied by default on macOS.
This also makes it simpler how to customize it
(use env var instead of hardcoded in the package.json)
#325