Use more helper runner helper methods #421
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flashdesignory
approved these changes
Aug 22, 2024
julienw
reviewed
Aug 26, 2024
| }; | ||
| frame.src = `${suite.url}`; | ||
| frame.onload = () => resolve(); | ||
| frame.onerror = () => reject(); |
|
|
||
| it("should call prepare on all suites", () => { | ||
| for (const suite in runner.suites) | ||
| suite.prepare.calledOnce(); |
There was a problem hiding this comment.
I'm surprised this is working. I think calledOnce is a property on a spy, not a function?
You probably wanted assert.calledOnce(suite.prepare). This makes me wonder if we really execute this line.
Debugging further it looks like indeed runner.suites is undefined, that's why the test passes (the for loop never runs anything). For loops are dangerous in tests :-)
I think you wanted _suites, not suites (also above in the before). I tried this but then I get more errors, so I'll let you debug :-D
Also it would be good to add something such as expect(runner._suites).not.to.have.length(0) to make sure we enter the loop.
rniwa
reviewed
Sep 18, 2024
| // seed. This is not a high quality RNG, but it's plenty good enough. | ||
| for (let i = 0; i < suites.length - 1; i++) { | ||
| let j = i + (this._suiteOrderRandomNumberGenerator() % (suites.length - i)); | ||
| let tmp = suites[i]; |
rniwa
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the runner a bit to be more flexible for upcoming experimental PRs.