Add emojis to a todomvc app #417
Conversation
|
How is typing that many emojis into todo list a realistic scenario? Wouldn't a more realistic scenario a mixture of one or two emojis and a dozen of non-emoji characters? |
That's a pretty easy change. I"ll adjust tomorrow! |
|
new list: "Electronic Granite Hat 👆🏻", |
|
I like the approach with treating it as a translation and having them interspersed with text. I don't really expect this to drive much performance work in engines but I don't have concerns with including it as this is a common pattern online. |
|
We discussed going forward with this as a new disabled-by-default test to make it easier for local testing |
flashdesignory
force-pushed
the
thor/emoji
branch
from
c7f819c
to
3ba788b
Compare
Awesome - made changes as discussed and will merge 😄 |
| Suites.push({ | ||
| name: "TodoMVC-Emoji", | ||
| url: "resources/todomvc/vanilla-examples/javascript-web-components/dist/index.html", | ||
| tags: ["todomvc", "experimental"], |
There was a problem hiding this comment.
adding experimental tag, since it's a test that uses a workload not in the experimental folder.
| name: "TodoMVC-Emoji", | ||
| url: "resources/todomvc/vanilla-examples/javascript-web-components/dist/index.html", | ||
| tags: ["todomvc", "experimental"], | ||
| disabled: true, |
There was a problem hiding this comment.
disabled by default 💪
Chose a random one (web-components), to add emojis to.
We can change that to any todomvc app though.
@kara