Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefine requestIdleCallback in the Next test for consistency. #243

Merged
merged 1 commit into from
Jun 18, 2023
Merged

Undefine requestIdleCallback in the Next test for consistency. #243

merged 1 commit into from
Jun 18, 2023

Conversation

rniwa
Copy link
Member

@rniwa rniwa commented Jun 17, 2023

We can undo this change once Safari / WebKit adds the support for requestIdleCallback.

@rniwa
Undefine requestIdleCallback in the Next test for consistency.
45cb12f 
We can undo this change once Safari / WebKit adds the support for requestIdleCallback.
@rniwa
Copy link
Member Author

rniwa commented Jun 17, 2023

http://localhost:8000/?suites=NewsSite-Next#details

Chrome

  • Before:

    • 16.9 ± 0.24
    • 16.5 ± 0.32
    • 17.1 ± 0.36

  • After:

    • 16.4 ± 0.81
    • 16.8 ± 0.49
    • 16.7 ± 0.50

Firefox

  • Before:

    • 16.6 ± 0.65
    • 16.5 ± 0.72
    • 16.5 ± 0.65

  • After:

    • 16.6 ± 0.57
    • 16.6 ± 0.40
    • 16.5 ± 0.49

** Safari **

  • Before:

    • 10.7 ± 0.37
    • 10.7 ± 0.63
    • 10.8 ± 0.43

  • After:

    • 10.5 ± 0.74
    • 10.7 ± 0.63
    • 10.5 ± 0.54

next-idle-callback.zip

@rniwa
Copy link
Member Author

rniwa commented Jun 17, 2023

See #240

@rniwa rniwa added the non-trivial change A change that affects benchmark results label Jun 17, 2023
@rniwa rniwa merged commit d50264b into main Jun 18, 2023
4 checks passed
@rniwa rniwa deleted the undefine-requestIdleCallback-in-next branch June 18, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgrins bgrins bgrins approved these changes

@flashdesignory flashdesignory flashdesignory approved these changes

@camillobruni camillobruni Awaiting requested review from camillobruni

@julienw julienw Awaiting requested review from julienw

Assignees
No one assigned
Labels
non-trivial change A change that affects benchmark results
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rniwa @bgrins @flashdesignory