Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use progress element #233

Merged
merged 5 commits into from
Jun 19, 2023
Merged

Use progress element #233

merged 5 commits into from
Jun 19, 2023

Conversation

camillobruni
Copy link
Contributor

No description provided.

@camillobruni camillobruni mentioned this pull request Jun 12, 2023
Merged
bgrins
bgrins reviewed Jun 12, 2023
View reviewed changes
index.html Outdated Show resolved Hide resolved
julienw
julienw approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@julienw julienw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An aria-label would be nice! Otherwise this looks good to me! Thanks for the change!

@camillobruni camillobruni added the trivial change A change that doesn't affect benchmark results label Jun 19, 2023
@camillobruni camillobruni merged commit 42a7b3b into WebKit:main Jun 19, 2023
4 checks passed
@camillobruni camillobruni deleted the 2023-06-12_add_progress_element branch June 19, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgrins bgrins bgrins left review comments

@flashdesignory flashdesignory flashdesignory left review comments

@julienw julienw julienw approved these changes

Assignees
No one assigned
Labels
trivial change A change that doesn't affect benchmark results
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@camillobruni @bgrins @flashdesignory @julienw