feat: check packages and report failures

src/main.rs

@@ -10,6 +10,7 @@ use combos::{feature_combos, ncr};
 use config::{load_config, Config};
 use intern::FeatureStorage;
 use metadata::{load_metadata, Package};
+use runner::check_with_features;
 
 fn main() {
     let cli: CLI = argh::from_env();
@@ -30,6 +31,8 @@ fn main() {
     #[cfg(debug_assertions)]
     println!("{:?}", metadata);
 
+    let mut failures = Vec::new();
+
     for package in metadata.packages {
         let Package { name, features } = package;
         let config = config.get(&name);
@@ -54,6 +57,22 @@ fn main() {
             }
 
             println!("\tChecking: {:?}", names);
+
+            let status = check_with_features(&name, &cli.manifest_path, &combo, &storage);
+
+            if !status.success() {
+                failures.push(format!(
+                    "Failed checking package {name} with features {names:?}"
+                ));
+            }
+        }
+    }
+
+    if !failures.is_empty() {
+        eprintln!("Failure report:");
+
+        for failure in failures {
+            eprintln!("\t{failure}");
         }
     }
 }

src/runner.rs

@@ -1,7 +1,7 @@
 use std::{
     ffi::OsStr,
     path::Path,
-    process::{Command, Output},
+    process::{Command, ExitStatus},
 };
 
 use crate::intern::{FeatureKey, FeatureStorage};
@@ -12,32 +12,25 @@ pub fn check_with_features(
     manifest_path: &Path,
     features: &[FeatureKey],
     storage: &FeatureStorage,
-) -> Output {
+) -> ExitStatus {
     // Create comma-separated list of features.
-    let features = features
-        .into_iter()
-        .map(|key| storage.get(*key).unwrap())
-        .fold(String::new(), |mut acc, f| {
-            acc.push_str(f);
-            acc.push(',');
-            acc
-        });
-
-    // Strip ending comma if it exists.
-    let features = match features.strip_suffix(',') {
-        Some(f) => f,
-        None => &features,
-    };
-
-    println!("Checking {package} with features {features}");
+    let features =
+        features
+            .iter()
+            .map(|key| storage.get(*key).unwrap())
+            .fold(String::new(), |mut acc, f| {
+                acc.push_str(f);
+                acc.push(',');
+                acc
+            });
 
     Command::new("cargo")
         .arg("check")
         .args([OsStr::new("--manifest-path"), manifest_path.as_os_str()])
         .args(["--package", package])
-        .args(["--color", "never"])
         .arg("--no-default-features")
-        .args(["--features", features])
-        .output()
+        .args(["--features", &features])
+        .arg("--quiet")
+        .status()
         .unwrap()
 }