Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuse cargo-generate with main branch #305

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

benfrankel
Copy link
Collaborator

@benfrankel benfrankel commented Sep 16, 2024

Related to #288.

Testing:

  • cargo generate -ap path/to/bevy_quickstart works
  • cargo run in the generated repo works
  • cargo run in the template itself works

Remaining tasks after this:

  • Update README.md (remove manual clone instructions, simplify cargo generate commands)
  • Remove "GitHub template" functionality
  • Delete cargo-generate.yaml workflow
  • Delete cargo-generate branch
  • Add ci-generate.yaml workflow to make sure cargo-generate works and the generated repo is functional (this can be workshopped in https://github.com/TheBevyFlock/bevy_new first)

@benfrankel benfrankel enabled auto-merge (squash) September 17, 2024 18:50
Copy link

@richchurcher richchurcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice.

src/lib.rs Show resolved Hide resolved
@benfrankel benfrankel merged commit 2985688 into TheBevyFlock:main Sep 19, 2024
4 checks passed
@benfrankel benfrankel deleted the generate branch September 19, 2024 15:49
benfrankel added a commit that referenced this pull request Sep 19, 2024
This is a followup to
#305.

After this, `ci-generate.yaml` is the only remaining task. That needs a
little more time to cook in
https://github.com/TheBevyFlock/bevy_new_minimal first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants