Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --locked to workflow cargo commands #296

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Add --locked to workflow cargo commands #296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c96c8b2
Add `--locked` to workflow cargo commands
benfrankel Sep 6, 2024
83193e3
Lock trunk as well
benfrankel Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ jobs:

- name: Run tests
run: |
cargo test --workspace --all-features --all-targets
cargo test --locked --workspace --all-features --all-targets
# Workaround for https://github.com/rust-lang/cargo/issues/6669
cargo test --workspace --all-features --doc
cargo test --locked --workspace --all-features --doc
# Run clippy lints.
clippy:
Expand All @@ -61,7 +61,7 @@ jobs:
sweep-cache: true

- name: Run clippy lints
run: cargo clippy --workspace --all-targets --all-features -- --deny warnings
run: cargo clippy --locked --workspace --all-targets --all-features -- --deny warnings

# Check formatting.
format:
Expand Down Expand Up @@ -101,4 +101,4 @@ jobs:
sweep-cache: true

- name: Check documentation
run: cargo doc --workspace --all-features --document-private-items --no-deps
run: cargo doc --locked --workspace --all-features --document-private-items --no-deps
4 changes: 2 additions & 2 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,13 +167,13 @@ jobs:
if: ${{ matrix.platform == 'web' }}
run: |
cargo binstall --no-confirm trunk wasm-bindgen-cli wasm-opt
trunk build --release --dist '${{ env.app }}'
trunk build --locked --release --dist '${{ env.app }}'
- name: Build binaries (non-Web)
if: ${{ matrix.platform != 'web' }}
run: |
for target in ${{ matrix.targets }}; do
cargo build --profile='${{ matrix.profile }}' --target="${target}" --no-default-features --features='${{ matrix.features }}'
cargo build --locked --profile='${{ matrix.profile }}' --target="${target}" --no-default-features --features='${{ matrix.features }}'
mv target/"${target}"/'${{ matrix.profile }}/${{ env.cargo_build_binary_name }}${{ matrix.binary_ext }}' tmp/binary/"${target}"'${{ matrix.binary_ext }}'
done
Expand Down