Fix load_resource stops proceeding if any of asset loading failed
#293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cart looks like your code made it back in :D |
benfrankel
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Bug and fix seem correct to me from the code. Approved, but deferring to @janhohenheim's review before merging.
Thanks for fixing this :)
benfrankel
reviewed
Sep 4, 2024
Co-authored-by: Ben Frankel <[email protected]>
janhohenheim
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vec::pop/Vec::pushtouches only the last element ofVec. So, if the asset there failed to load,load_resource_assetswouldn't process remaining asset any more. This PR changes it to useVecDeque::push_back/VecDeque::pop_frontinstead.