Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not create a new issue on cargo-generate merge conflicts if one already exists #277

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

BD103
Copy link
Member

@BD103 BD103 commented Aug 16, 2024

Closes #276.

This uses gh to query for open issues, counts them, then exits early if any exist.

Copy link
Collaborator

@benfrankel benfrankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits but looks good.

.github/workflows/cargo-generate.yaml Outdated Show resolved Hide resolved
.github/workflows/cargo-generate.yaml Outdated Show resolved Hide resolved
.github/workflows/cargo-generate.yaml Outdated Show resolved Hide resolved
@BD103 BD103 requested a review from benfrankel August 16, 2024 15:50
@BD103
Copy link
Member Author

BD103 commented Aug 16, 2024

@benfrankel out of curiosity, why do you prefer to make all $VARIABLES as "${VARIABLES}"? As far as I can tell, they do the same thing.

@benfrankel
Copy link
Collaborator

benfrankel commented Aug 16, 2024

@BD103 They help disambiguate in the general case. For example:

echo "$FOO-bar"
echo "${FOO}-bar"
echo "${FOO-bar}"

Ofc if you're just doing "$FOO", there's no disambiguation needed, but in that case I still prefer "${FOO}" for the consistency and so that I never have to even think "do I need {} here?", I just always add them.

Also see the Google style guide: https://google.github.io/styleguide/shellguide.html#s5.6-variable-expansion

@benfrankel benfrankel enabled auto-merge (squash) August 16, 2024 17:12
@benfrankel benfrankel merged commit 62840b5 into TheBevyFlock:main Aug 16, 2024
4 checks passed
@BD103 BD103 deleted the cargo-generate-issue-dedup branch August 16, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not open new cargo-generate merge conflict issue when one exists
3 participants