Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor label #260

Merged
merged 2 commits into from
Aug 10, 2024
Merged

Refactor label #260

merged 2 commits into from
Aug 10, 2024

Conversation

janhohenheim
Copy link
Member

No description provided.

@janhohenheim janhohenheim enabled auto-merge (squash) August 10, 2024 21:36
@benfrankel
Copy link
Collaborator

benfrankel commented Aug 10, 2024 •
edited
Loading

Repeat this for the header widget? Or is that non-trivial due to the background color

@janhohenheim
Copy link
Member Author

Exactly, the bg color would no longer work the same

benfrankel
benfrankel approved these changes Aug 10, 2024
View reviewed changes
Copy link
Collaborator

@benfrankel benfrankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving under the assumption that you checked that everything looks fine.

@janhohenheim janhohenheim merged commit 4b96cd7 into main Aug 10, 2024
4 checks passed
@janhohenheim janhohenheim deleted the refactor-ui branch August 10, 2024 21:54
benfrankel pushed a commit to benfrankel/bevy_quickstart that referenced this pull request Aug 11, 2024
@janhohenheim @benfrankel
Refactor label (TheBevyFlock#260)
6942d95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benfrankel benfrankel benfrankel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janhohenheim @benfrankel