Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notification settings, which allows muting decky/plugin toast notifications #479

Merged
merged 3 commits into from
Jun 24, 2023

Conversation

JohnnyCrazy
Copy link
Member

Please tick as appropriate:

  • I have tested this code on a steam deck or on a PC
  • My changes generate no new errors/warnings
  • This is a bugfix/hotfix
  • This is a new feature

If you're wanting to update a translation or add a new one, please use the weblate page: https://weblate.werwolv.net/projects/decky/

Description

This fixes issue: #473

image

@JohnnyCrazy JohnnyCrazy self-assigned this Jun 11, 2023
@JohnnyCrazy JohnnyCrazy requested a review from a team June 11, 2023 09:46
@TrainDoctor TrainDoctor added the enhancement New feature or request label Jun 11, 2023
@ttang4299
Copy link

ttang4299 commented Jun 19, 2023

Hey @JohnnyCrazy , I don't know if there's room to implement a further change, but if you know how to toggle notifications for successful and/or unsuccessful update checks (or at least add a section where it can show when a successful update check was last performed), but if you know if this could be implemented, it would be very cool if you could add this whenever you have the time to

Reference: #425

frontend/src/notification-service.tsx Outdated Show resolved Hide resolved
@JohnnyCrazy JohnnyCrazy merged commit ef9afa8 into main Jun 24, 2023
10 checks passed
@JohnnyCrazy JohnnyCrazy deleted the notification-settings branch June 24, 2023 10:59
@Kalidibus
Copy link

@JohnnyCrazy - Thank you so much for this! The notifications were a huge immersion breaker when in game.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants