Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updating README #72

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

boekhorstb1
Copy link
Contributor

@boekhorstb1 boekhorstb1 commented Aug 22, 2024

  • updateing README.md

Depends: #73

@boekhorstb1 boekhorstb1 self-assigned this Aug 22, 2024
@boekhorstb1 boekhorstb1 force-pushed the prs/adapt-docs-and-makefile branch 5 times, most recently from bda2241 to a7e3fb1 Compare August 22, 2024 11:36
Copy link
Contributor

@NotTheEvilOne NotTheEvilOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a separate PR for the Makefile changes.

README.md Outdated Show resolved Hide resolved
README.md Outdated

_Adapt the config.yml to your need_: especially enter the correct paths for ssh-keys, kubernetes configuration and ceph configuration (all these configuration files need to be provided!).
Note:
- for the testbed there is a helper script to download the configs from the testbed. These helperscripts need correct `.ssh/config` entries to work (take a look at [scripts/get_configs_from_testbed](scripts/get_configs_from_testbed.sh) for an example).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the provided testbed scripts to a osism sub-directory. :)

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@boekhorstb1
Copy link
Contributor Author

boekhorstb1 commented Aug 26, 2024

Please create a separate PR for the Makefile changes.

ok I removed makefile changes in this PR and I added makefile updates into this pr:

#73

@NotTheEvilOne NotTheEvilOne force-pushed the prs/enhance-ceph-pools branch 7 times, most recently from 75c6ab3 to 463e5fb Compare September 3, 2024 08:07
Base automatically changed from prs/enhance-ceph-pools to main September 3, 2024 20:52
@boekhorstb1 boekhorstb1 marked this pull request as ready for review September 4, 2024 07:48
@boekhorstb1 boekhorstb1 changed the title docs and setup: updating Makefile to work docs: updating README Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants